Robin Leroy
Robin Leroy
> Thoughts from Markus: > CheckProperties seems to swallow the exception, and finishes with exit code 0. This could hide real problems. CheckProperties was turned into a CI step by...
Indeed. Which would fail, if it were a thing that could fail. In fact it fails so much (because of unmaintained regexes) that the checkEnum failure isnโt actually printed (but...
> changing checkEnum() to throw, and fixing what then fails, also sounds painful... It is not too bad for the current version. On older versions it is a different story...
> What is left on this issue? All of it? It was created to allow us to close the specific issue reported in https://github.com/unicode-org/icu4x/issues/4417, but word segmentation is still wrong...
Yes, I see https://github.com/unicode-org/icu4x/pull/6442 fixed this (by duplicating most of the states rather than hoisting the ZWJ handling into the code).
It would be interesting to know whether it still works if you get rid of the copy of principia.so in /Applications/KSP_osx/KSP.app/Contents/Frameworks/principia.so. That one is probably not going to be found...
> Can you please update the segmentation code & data as needed? In this branch, or in a separate PR? (As discussed, I will want to do that with several...
Sounds reasonable, I will add commits into this one then.
Oh, this is fun: `createRuleBasedBreakIterator: ICU Error "U_BRK_RULE_EMPTY_SET" at line 292, column 5` This is the set `[$IS & [\p{ea=F}\p{ea=W}\p{ea=H}]]` which got emptied by UTC-179-C30: > [[179-C30](https://www.unicode.org/cgi-bin/GetL2Ref.pl?179-C30)] Consensus: Change the...
> It sounds like this is still WIP, and I see that a number of the CI checks are unhappy. Yes; I have brought in all the work that was...