egg-view-assets icon indicating copy to clipboard operation
egg-view-assets copied to clipboard

feat: dev mode support custom asset url host

Open hubcarl opened this issue 5 years ago • 4 comments

Checklist
  • [ ] npm test passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Add unit test for follow PR:

  • https://github.com/eggjs/egg-view-assets/pull/33
  • https://github.com/eggjs/egg-view-assets/pull/36

hubcarl avatar Aug 15 '20 06:08 hubcarl

Codecov Report

Merging #38 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          196       198    +2     
=========================================
+ Hits           196       198    +2     
Impacted Files Coverage Δ
config/config.default.js 100.00% <ø> (ø)
app.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update feb5f41...6aa47a4. Read the comment docs.

codecov[bot] avatar Aug 24 '20 01:08 codecov[bot]

@popomore need review, then publish

hubcarl avatar Aug 27 '20 01:08 hubcarl

这。。。唉。。。

big-camel avatar Jun 06 '21 04:06 big-camel

为啥不合并呢,在开发时,想用手机访问开发环境只能硬编码了

big-camel avatar Jun 06 '21 04:06 big-camel