egg-validate icon indicating copy to clipboard operation
egg-validate copied to clipboard

更新types, 更新travis.yml 最新的npminstall只支持node 8

Open mengfei0053 opened this issue 4 years ago • 5 comments

Checklist
  • [x] npm test passes
  • [x] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [x] commit message follows commit guidelines
Affected core subsystem(s)
Description of change

mengfei0053 avatar Feb 24 '21 10:02 mengfei0053

Codecov Report

Merging #24 (b97f883) into master (c4326d2) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines            9         9           
=========================================
  Hits             9         9           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c4326d2...60e7551. Read the comment docs.

codecov[bot] avatar Feb 24 '21 10:02 codecov[bot]

@atian25 大锅,你看这个pr可以合并了吗?最近用到 validator + ts 也遇到了类型提示不明显的情况,利用声明合并怎么都覆盖不了插件里面的类型声明,可能还是从源头上加上类型定义比较好解决一点。

image

Runtu4378 avatar May 06 '21 11:05 Runtu4378

返回值建议还是取 Parameter.ValidateError[] 而不是 void ,当校验通过后返回的类型是 Parameter.ValidateError[],失败直接抛错也不会执行到后续的代码,void 没有意义。

image

OnlyFlyer avatar May 14 '21 10:05 OnlyFlyer

我也遇到了覆盖不了插件中的*.d.ts声明的问题,希望早日Merge这个PR

kerryChen95 avatar Jan 26 '22 09:01 kerryChen95

我也遇到了覆盖不了插件中的*.d.ts声明的问题,希望早日Merge这个PR

直接用parameter

andyFang94 avatar Nov 14 '22 09:11 andyFang94