egg-scripts icon indicating copy to clipboard operation
egg-scripts copied to clipboard

feat(lib,test,ci):drop support of Node <=6.x and use async function

Open qingdengyue opened this issue 6 years ago • 3 comments

Checklist
  • [x] npm test passes
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines
Affected core subsystem(s)
Description of change

1.Drop support of Node <=6.x 2.Change generator to async function 3.CI remove Node 6 support

qingdengyue avatar May 06 '19 11:05 qingdengyue

Codecov Report

Merging #37 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files           6        6           
  Lines         210      210           
=======================================
  Hits          207      207           
  Misses          3        3
Impacted Files Coverage Δ
lib/helper.js 100% <100%> (ø) :arrow_up:
lib/cmd/start.js 99.18% <100%> (ø) :arrow_up:
lib/cmd/stop.js 93.54% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7ae9cb0...149c965. Read the comment docs.

codecov[bot] avatar May 06 '19 12:05 codecov[bot]

thanks for your work, but I don't think it's the right time to release a major version.

it's better to wait for https://github.com/eggjs/egg/issues/3644 (Better Single Process / CLI Plugin System) and see what's need then release one major version together.

so could we just keep this PR for a while? thanks for your works again.

atian25 avatar May 07 '19 00:05 atian25

@atian25 ok.thanks.

qingdengyue avatar May 07 '19 00:05 qingdengyue

https://github.com/eggjs/egg-scripts/pull/58

fengmk2 avatar Feb 19 '24 13:02 fengmk2