egg-scripts icon indicating copy to clipboard operation
egg-scripts copied to clipboard

feat: add alinode log dir rely on config logger dir

Open a526672351 opened this issue 6 years ago • 5 comments

加入依赖应用config日志自定义目录,配置alinode日志目录位置,达到应用独立存储alinode日志。

a526672351 avatar Apr 16 '18 16:04 a526672351

Codecov Report

Merging #21 into master will decrease coverage by 1.03%. The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage     100%   98.96%   -1.04%     
==========================================
  Files           6        6              
  Lines         204      193      -11     
==========================================
- Hits          204      191      -13     
- Misses          0        2       +2
Impacted Files Coverage Δ
lib/cmd/start.js 98.19% <71.42%> (-1.81%) :arrow_down:
lib/command.js 100% <0%> (ø) :arrow_up:
lib/cmd/stop.js 100% <0%> (ø) :arrow_up:
lib/helper.js 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08f8ea9...6cba28a. Read the comment docs.

codecov[bot] avatar Apr 16 '18 16:04 codecov[bot]

@atian25 alinode 这个目录是不是可以在插件生成?

popomore avatar Aug 10 '18 03:08 popomore

应该是可以的, cc @JacksonTian

atian25 avatar Aug 10 '18 05:08 atian25

@JacksonTian 如果能在插件配这个路径,那就不用这里加了。

popomore avatar Aug 23 '18 11:08 popomore

执行时机不一样吧,现在他们 runtime 是启动期就需要这个环境变量了,除非是插件启动后再调用 commandx 传递过去。但在这之前的日志呢?

atian25 avatar Aug 23 '18 14:08 atian25

已收到!

a526672351 avatar Feb 19 '24 13:02 a526672351