egg-rest icon indicating copy to clipboard operation
egg-rest copied to clipboard

feat: support load typescript file

Open sabakugaara opened this issue 5 years ago • 7 comments

Checklist
  • [x] npm test passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines
Affected core subsystem(s)
Description of change

sabakugaara avatar Jan 18 '20 07:01 sabakugaara

code from: https://github.com/eggjs/egg-rest/pull/21, fix lint error

sabakugaara avatar Jan 18 '20 07:01 sabakugaara

Codecov Report

Merging #23 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files           5        5           
  Lines         185      185           
=======================================
  Hits          179      179           
  Misses          6        6
Impacted Files Coverage Δ
lib/load_api.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 85a0098...3f51e27. Read the comment docs.

codecov[bot] avatar Jan 18 '20 07:01 codecov[bot]

这 2 个 PR 的关系是?

那边还有几个 Review 问题还没解决

atian25 avatar Jan 21 '20 06:01 atian25

这 2 个 PR 的关系是?

那边还有几个 Review 问题还没解决

代码是一样的,只有一个 lint 问题修复了,但是看原作者好像没打算继续更新。 所以,建议在这个分支上继续

sabakugaara avatar Jan 21 '20 13:01 sabakugaara

@whxaxes 看下

atian25 avatar Jan 22 '20 02:01 atian25

ping @whxaxes

sabakugaara avatar Mar 10 '20 03:03 sabakugaara

补一下单测

whxaxes avatar Mar 10 '20 03:03 whxaxes