egg-multipart icon indicating copy to clipboard operation
egg-multipart copied to clipboard

Published 20 hours ago • verified publisher icon eggjs

feat: Make invalid filename error detectable

Open sm2017 opened this issue 5 years ago • 3 comments

Checklist
  • [x] npm test passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [x] commit message follows commit guidelines
Affected core subsystem(s)

Nothing

Description of change

Allow to detect invalid file name error

sm2017 avatar Dec 06 '18 13:12 sm2017

@dead-horse please review

sm2017 avatar Dec 08 '18 14:12 sm2017

@dead-horse please review @atian25 please accept PR

sm2017 avatar Dec 15 '18 07:12 sm2017

Codecov Report

Merging #23 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   96.96%   96.98%   +0.01%     
==========================================
  Files           5        5              
  Lines         165      166       +1     
==========================================
+ Hits          160      161       +1     
  Misses          5        5
Impacted Files Coverage Δ
app.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b50151f...95b5d8c. Read the comment docs.

codecov[bot] avatar Dec 18 '18 03:12 codecov[bot]

the baseline has refactor, if you still need this feature, fell welcome to rebase it and add some tests thanks

atian25 avatar Sep 29 '22 15:09 atian25