egg-logrotator icon indicating copy to clipboard operation
egg-logrotator copied to clipboard

rename class name to HourRotator

Open kaidiren opened this issue 4 years ago • 2 comments

this file is Hour Rotator not day Rotator

Checklist
  • [ ] npm test passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines
Affected core subsystem(s)
Description of change

kaidiren avatar Feb 23 '21 06:02 kaidiren

Codecov Report

Merging #29 (1899199) into master (46b6876) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files          14       14           
  Lines         210      210           
=======================================
  Hits          202      202           
  Misses          8        8           
Impacted Files Coverage Δ
app/lib/hour_rotator.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 46b6876...230e099. Read the comment docs.

codecov[bot] avatar Feb 23 '21 06:02 codecov[bot]

👍

elvinn avatar Mar 02 '21 12:03 elvinn