egg-grpc icon indicating copy to clipboard operation
egg-grpc copied to clipboard

新增 grpc ssl 安全配置

Open xdxiaodong opened this issue 5 years ago • 3 comments

Checklist
  • [ ] npm test passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines
Affected core subsystem(s)
Description of change

新增 grpc client ssl 安全配置

xdxiaodong avatar Dec 03 '19 15:12 xdxiaodong

Thanks for your contributing. 🎉

Please make sure that the code is checked through the checklist and pass the CI testing.

We might need some tests to test this new feature.

Otherwise, I notice the package name (which in package.json) has been changed, we should keep the name as before as send it to npm.

It might also includes a breaking change which is unnecessary - The configuration of this plugin didn't support multiple entries so the configurations could set the first client configurations directly without clients layer. If we want to make it supports the multiple entries we might need to keep supporting directly with one client configuration. We can check if the clients field is exists at the first time.

JasinYip avatar Dec 09 '19 03:12 JasinYip

reference to https://github.com/eggjs/egg/issues/4077

JasinYip avatar Dec 09 '19 03:12 JasinYip

Thanks for your contributing. 🎉

Please make sure that the code is checked through the checklist and pass the CI testing.

We might need some tests to test this new feature.

Otherwise, I notice the package name (which in package.json) has been changed, we should keep the name as before as send it to npm.

It might also includes a breaking change which is unnecessary - The configuration of this plugin didn't support multiple entries so the configurations could set the first client configurations directly without clients layer. If we want to make it supports the multiple entries we might need to keep supporting directly with one client configuration. We can check if the clients field is exists at the first time.

https://github.com/xdxiaodong/egg-grpc-x

xdxiaodong avatar Dec 09 '19 05:12 xdxiaodong