egg-graphql icon indicating copy to clipboard operation
egg-graphql copied to clipboard

增加ts的支持

Open ShuaiShuaiguo opened this issue 6 years ago • 15 comments

Checklist
  • [x] npm test passes
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines
Affected core subsystem(s)
Description of change

ShuaiShuaiguo avatar Jun 08 '18 06:06 ShuaiShuaiguo

Codecov Report

Merging #15 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #15   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      7    -1     
  Lines          94     92    -2     
=====================================
- Hits           94     92    -2
Impacted Files Coverage Δ
app/extend/context.js 100% <ø> (ø) :arrow_up:
lib/loader/graphql-loader.js 100% <100%> (ø)
agent.js 100% <100%> (ø) :arrow_up:
app.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0248cb2...ab3006d. Read the comment docs.

codecov[bot] avatar Jun 08 '18 06:06 codecov[bot]

什么情况 ,为什么不合并呢

alex86w avatar Oct 10 '18 08:10 alex86w

@whxaxes 这个 PR 进度如何?

@ShuaiShuaiguo 需要 Rebase 下

atian25 avatar Oct 10 '18 09:10 atian25

有进展吗?

zhanba avatar Nov 29 '18 09:11 zhanba

没人维护了吗?进度就这么停着?

DarrenHou1993 avatar Dec 24 '18 03:12 DarrenHou1993

进展如何?

yuu2lee4 avatar Feb 11 '19 08:02 yuu2lee4

看底部,需要 rebase 处理冲突问题。

atian25 avatar Feb 12 '19 01:02 atian25

@ShuaiShuaiguo 方便处理下冲突吗?想升级到 egg-bin + egg-ts-helper 的方式,egg-graphql 加载的是 js 文件,导致 egg-bin dev 开发时 app/graphql 文件夹对应 js 文件不会自动生成

Carrotzpc avatar Apr 14 '19 14:04 Carrotzpc

Codecov Report

Merging #15 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #15   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      7    -1     
  Lines         110     92   -18     
=====================================
- Hits          110     92   -18
Impacted Files Coverage Δ
app/extend/context.js 100% <ø> (ø) :arrow_up:
app.js 100% <100%> (ø) :arrow_up:
agent.js 100% <100%> (ø) :arrow_up:
lib/loader/graphql-loader.js 100% <100%> (ø)
app/middleware/graphql.js 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d89ee5...045cc34. Read the comment docs.

codecov-io avatar Apr 15 '19 06:04 codecov-io

Codecov Report

Merging #15 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #15   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      7    -1     
  Lines         110    102    -8     
=====================================
- Hits          110    102    -8
Impacted Files Coverage Δ
app/extend/context.js 100% <ø> (ø) :arrow_up:
lib/loader/graphql-loader.js 100% <100%> (ø)
app.js 100% <100%> (ø) :arrow_up:
agent.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d89ee5...3026c75. Read the comment docs.

codecov-io avatar Apr 15 '19 06:04 codecov-io

非常抱歉,由于工作原因且graphql项目始终无法落地,故关注度降低。egg-ts-helper支持请参照,希望提PR

ShuaiShuaiguo avatar Apr 15 '19 07:04 ShuaiShuaiguo

@ShuaiShuaiguo 感谢,commits 可能需要 rebase 合并下,egg-ts-helper 后面我可以做下支持

Carrotzpc avatar Apr 15 '19 10:04 Carrotzpc

自己整合了下代码。。。着急的童鞋可以用这个版本: https://www.npmjs.com/package/@switchdog/egg-graphql/v/3.1.0-beta.1

Carrotzpc avatar Apr 19 '19 03:04 Carrotzpc

https://github.com/eggjs/egg/issues/3092

yuu2lee4 avatar Apr 24 '19 11:04 yuu2lee4

大佬们,啥时候 ts 支持能落地啊 ...

droplet-js avatar Mar 19 '20 07:03 droplet-js