eggdrop icon indicating copy to clipboard operation
eggdrop copied to clipboard

Only configure modules, that have at least one .c file

Open michaelortmann opened this issue 5 years ago • 0 comments

Found by: Geo Patch by: michaelortmann Fixes:

One-line summary: Workaround for design issue with current built-system

Additional description (if needed): make config picks up any folder under src/mod and later make tries to execute the Makefile in that folder If you manually copy a module into src/mod make config will find it And if you remove .c files under src/mod/*/ make will fail That is what also happens when git checkout checks out a branch that has one module less than the current branch and that has been configured. Stale folder under src/mod remains, but with no source inside This Patch detects this case (folder, but without a single .c) and filters it out in make config

We could also add debug log for this case in that if-statement.

See also #72

Test cases demonstrating functionality (if applicable): Works for pbkdf2 in my case, but its only a proof of concept patch, someone with more bash and modconfig knowledge should look at the code i wrote.

michaelortmann avatar Apr 04 '20 23:04 michaelortmann