stack-overflow-copy-paste icon indicating copy to clipboard operation
stack-overflow-copy-paste copied to clipboard

WIP: added flip-bool.js

Open linzmeyer opened this issue 6 years ago β€’ 3 comments

I believe everything is good to go. I'm not sure on 2 things: 1. How to check my code coverage report. 2. I need help with the proper commit message format.

Please let me know if you need anything from me at this point.

Thank you for your time! This has been a great exercise for me!

linzmeyer avatar Feb 18 '19 21:02 linzmeyer

Codecov Report

Merging #254 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #254   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          95     95           
  Lines         465    465           
=====================================
  Hits          465    465

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update c8ee1a3...8a61c06. Read the comment docs.

codecov-io avatar Feb 18 '19 21:02 codecov-io

Hi @linzmeyer. Well-done πŸ‘. I think everything is looking good. The codecov report is in charge of the code coverage and I think it's good to go πŸ‘ For commit message, since you adding new feature you could use a format like this: feat(flip-bool): add 'flip-bool' function

For more details check out https://github.com/conventional-changelog-archived-repos/conventional-changelog-angular/blob/master/convention.md

bolah2009 avatar Feb 18 '19 22:02 bolah2009

Thanks @bolah2009. @linzmeyer, would you like to add tests for your new function as well as include it in the exports in src/index.js?

kentcdodds avatar Feb 18 '19 22:02 kentcdodds