youtube-comment-downloader icon indicating copy to clipboard operation
youtube-comment-downloader copied to clipboard

request.get timeouts, process-list.sh, requirements.txt

Open sickcodes opened this issue 5 years ago • 5 comments

Add timeouts for requests, otherwise requests can hang forever.

Added process-list.sh

./process-list.sh id_list.txt

Added requirements.txt for pipenv, pyenv, conda QOL.

sickcodes avatar Oct 19 '20 11:10 sickcodes

your pull request is awesome. i love it

cpuuntery avatar Nov 17 '20 12:11 cpuuntery

your pull request is awesome. i love it

Thanks!

@egbertbouman any plans to merge?

sickcodes avatar Nov 18 '20 13:11 sickcodes

I'm not sure about supporting bulk processing like this, as it is platform-dependent. Adding a timeout to the HTTP requests and requirements.txt does make sense, though.

egbertbouman avatar Nov 18 '20 15:11 egbertbouman

Since it seems that more people want this functionality, I guess we could add something similar to the code I posted here. And just add this functionality to downloader.py.

egbertbouman avatar Nov 18 '20 16:11 egbertbouman

I'm not sure about supporting bulk processing like this, as it is platform-dependent.

Adding a timeout to the HTTP requests and requirements.txt does make sense, though.

True, it's just a script tho, maybe put in a tools folder?

requirements is pretty much standard otherwise users have to open the python file and find it anyway.

Script good for docker, VPS, Linux and Mac users.

In fact, Windows subsystem for Linux users can use it too now.

Edit: timeouts are essential for python requests otherwise it can hang forever

sickcodes avatar Nov 18 '20 20:11 sickcodes

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Feb 14 '24 02:02 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Feb 22 '24 02:02 github-actions[bot]