youtube-comment-downloader
youtube-comment-downloader copied to clipboard
request.get timeouts, process-list.sh, requirements.txt
Add timeouts for requests, otherwise requests can hang forever.
Added process-list.sh
./process-list.sh id_list.txt
Added requirements.txt for pipenv, pyenv, conda QOL.
your pull request is awesome. i love it
your pull request is awesome. i love it
Thanks!
@egbertbouman any plans to merge?
I'm not sure about supporting bulk processing like this, as it is platform-dependent. Adding a timeout to the HTTP requests and requirements.txt does make sense, though.
Since it seems that more people want this functionality, I guess we could add something similar to the code I posted here.
And just add this functionality to downloader.py.
I'm not sure about supporting bulk processing like this, as it is platform-dependent.
Adding a timeout to the HTTP requests and requirements.txt does make sense, though.
True, it's just a script tho, maybe put in a tools folder?
requirements is pretty much standard otherwise users have to open the python file and find it anyway.
Script good for docker, VPS, Linux and Mac users.
In fact, Windows subsystem for Linux users can use it too now.
Edit: timeouts are essential for python requests otherwise it can hang forever
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This PR was closed because it has been stalled for 7 days with no activity.