ballistica icon indicating copy to clipboard operation
ballistica copied to clipboard

Game gets stuck on exit

Open Dliwk opened this issue 1 year ago • 1 comments

Description

This blocking fgets call seems to prevent game from gracefully exiting: https://github.com/efroemling/ballistica/blob/978f32f9f098bd0ff1dc64b496ec31cf493ded09/src/ballistica/base/support/stdio_console.cc#L52-L55

Pressing Ctrl+D (and triggering EOF) allows game to finally shut down.

I didn't find any inter-thread-signal-forwarding logic which could trigger EOF, but this problem didn't exist for me some time ago. :man_shrugging:

Steps to reproduce

  1. Launch BombSquad
  2. Close BombSquad
  3. Do not press Ctrl+D
  4. ???

Machine

Platform: Fedora Linux 39 Commit: https://github.com/efroemling/ballistica/tree/978f32f9f098bd0ff1dc64b496ec31cf493ded09/

Dliwk avatar Jan 26 '24 11:01 Dliwk

I can vouch This is reproducible everytime on my machine(arch Linux)

Loup-Garou911XD avatar Mar 14 '24 01:03 Loup-Garou911XD

This seems to be fixed now https://github.com/efroemling/ballistica/blob/main/CHANGELOG.md#1735-build-21889-api-8-2024-06-20

Dliwk avatar Aug 04 '24 20:08 Dliwk