ballistica
ballistica copied to clipboard
efroemling
Reset Mapping button in controllers config menu
Description
As suggested by @komasio71, this implements a "reset" button in the "Configure X" menus that sets your button mappings to their default values. That's it.
https://github.com/efroemling/ballistica/assets/79161340/d5613adf-5777-4bd2-8af6-89479d074aaa
I don't think this requires much explanation; it assists you on wiping your button binds in case you set them to something silly and non-functional, if you're not happy with your current binds, or literally any other reason on which you would need to clear them out. Not a big change but it would be appreciated by tons of people and controllers alike :).
EFRO NOTE:
This change has raw text strings, so having new translatable lines would be very much appreciated!
Now, look at this very cool table telling you this is a new feature:
| Type | |
|---|---|
| ✓ | :sparkles: New feature |
my idea!! :D (this comment was supposed to be posted a week now but anyway)
I'm too tired to change the whole input reset ordeal into another file, efro please just add your magical # pylint: disable=too-many-lines if you agree...
This is a great addition; thanks! My one bit of feedback would be that I think the button should be a bit less prominent. I'd prefer to have 'Cancel' and 'Save' be the primary two actions users see. Could the reset button be a more muted color, smaller, and maybe tucked into the bottom or corner? Perhaps similar to the 'advanced' button in the controller window?..
This is a great addition; thanks! My one bit of feedback would be that I think the button should be a bit less prominent. I'd prefer to have 'Cancel' and 'Save' be the primary two actions users see. Could the reset button be a more muted color, smaller, and maybe tucked into the bottom or corner? Perhaps similar to the 'advanced' button in the controller window?..
Sure! I'll move the button to a corner real quick! (not as quick as I'll need to make sure it doesn't break on smaller UI sizes 🤠)
Alternately I could see this also working as a menu entry under a '...' button. That would also give us a place to add any other functionality later (and the advanced button could go there too). Just a thought.
Oh well, I'll leave the CI thing there; I've been trying to install it on VSC for a while, but it keeps plaguing the project with nonsensical Mypy(no-any-unimported) errors.