ballistica icon indicating copy to clipboard operation
ballistica copied to clipboard

Accept "fairydust" as an emit type in ba.emitfx()

Open ritiek opened this issue 1 year ago • 1 comments

  • [x] Add a CHANGELOG entry if your change is non-trivial.
  • [x] Ensure make preflight completes successfully.

Description

For example, this now works:

ba.emitfx(
    position=(10, 10, 0),
    velocity=(0, 2, 0),
    count=5,
    spread=0.1,
    emit_type="fairydust",
)

Seems to me it got missed but feel free to close this if there's a reason it wasn't done on purpose.

Type of Changes

| ✓ | :sparkles: New feature |

ritiek avatar Sep 08 '22 17:09 ritiek

Running make update should fix failing CI job.

Dliwk avatar Sep 08 '22 17:09 Dliwk

Thanks for this!

efroemling avatar Sep 22 '22 20:09 efroemling

@efroemling I think you will have to make update since it causing the ci to fail on master.

ritiek avatar Sep 22 '22 21:09 ritiek

I'm on it; should be all fixed in a few mins 👍

efroemling avatar Sep 22 '22 21:09 efroemling