Effi Ofer

The code to clean job changed a couple of weeks ago in https://github.com/kubestellar/kubestellar/commit/fdb4395a238056eeb6174b9c60dd9e010eebec63#diff-0d3845377da95b92d2ccd094e1375b1fe7610fe8109825376764826a7591cc09. A shell based job cleaning test was delivered as part of this change. If you don't mind...

The code to cleanup the controller-uid works as designed. However, it only deletes the controller-uid and batch.kubernetes.io/controller-uid from spec.template.metadata.labels. Does it need to also delete the controller-uid and batch.kubernetes.io/controller-uid from...

@nirrozenbaum following your suggestion we get the following: ``` message: 'Failed to apply manifest: Job.batch "pi" is invalid: [spec.template.metadata.labels[controller-uid]: Required value: must be ''11e7aa6c-0694-4d65-8261-cf42f687466d'', spec.template.metadata.labels[job-name]: Required value: must be ''pi'',...

Good question about the annotation. It didn't appear in Paolo's original manifestwork. I don't see it in the yaml used to create the job (the same one Paolo used). It...

Of course I meant I would try it. Sadly however it did not help. ``` apiVersion: work.open-cluster-management.io/v1 kind: ManifestWork metadata: annotations: transport.kubestellar.io/originOwnerReferenceBindingGeneration: "1" creationTimestamp: "2024-03-25T10:06:37Z" finalizers: - cluster.open-cluster-management.io/manifest-work-cleanup generation: 1...

Yes, I tried patching the manifestwork object directly, but didn't see a lastTransitionTime update (maybe I didn't wait enough), so each time I start with a clean system and a...

Removing the empty fields, specifically the spec.template.metadate.labels results in an error. Looks like that field is required. I still have a few more things to try. ``` message: 'Failed to...

``` apiVersion: work.open-cluster-management.io/v1 kind: ManifestWork metadata: annotations: transport.kubestellar.io/originOwnerReferenceBindingGeneration: "2" creationTimestamp: "2024-03-25T13:23:46Z" finalizers: - cluster.open-cluster-management.io/manifest-work-cleanup generation: 2 labels: transport.kubestellar.io/originOwnerReferenceBindingKey: jobs transport.kubestellar.io/originWdsName: wds1 name: jobs-wds1 namespace: cluster1 resourceVersion: "850" uid: f7806227-5b8f-419c-8ca4-4d727625b122 spec:...

Can we use helm's --post-renderer parameter to add the labels (possibly with the use of kustomize)? https://helm.sh/docs/topics/advanced/ @clubanderson did the hackaton took place on the weekend as per the opening...

Is this still needed?