Effekseer icon indicating copy to clipboard operation
Effekseer copied to clipboard

Russian localization

Open ghost opened this issue 5 years ago • 40 comments

Hello! I've got a question. Is there any way to localize Effekseer interface? I see Japanese and English only. And I'd like to add another one - Russian. But I cannot understand to what I start with? There are many files in the directory "languages". :-)

ghost avatar Feb 24 '20 16:02 ghost

Effekseer's localization is a bit complicated.

Some texts are written in those CSV and converted json and text with python script https://github.com/effekseer/Effekseer/tree/master/Dev/release/resources/languages

Other texts are written in the code like this. https://github.com/effekseer/Effekseer/blob/master/Dev/Editor/EffekseerCore/Data/AlphaCrunchValues.cs#L47

In addition, you need to add enum in this https://github.com/effekseer/Effekseer/blob/master/Dev/Editor/EffekseerCore/Define.cs#L72

If you have a good motivation, please come to Discord or Slack. I can discuss in a detail including improving localization system.

durswd avatar Feb 26 '20 17:02 durswd

Discord or slack..

https://effekseer.github.io/en/support.html

durswd avatar Feb 26 '20 17:02 durswd

Ooh, it's not easy. Now my motivation is falling ;-) Anyway, I think that I'll get down to work in my free time. When I'm ready I'll use Slack.

ghost avatar Feb 26 '20 19:02 ghost

I will try to make it easily

durswd avatar Feb 27 '20 00:02 durswd

We start to discuss improving localization. It may be improved few weeks ago.

durswd avatar Feb 27 '20 05:02 durswd

OK. We'll be waiting. I imagine how difficult is to refactor.

ghost avatar Feb 27 '20 15:02 ghost

I'm sorry to delay. Because releasing of version 1.5 consumed my time. I start to improve it.

durswd avatar Mar 25 '20 00:03 durswd

It's ok! I guessed as much. ;-)

ghost avatar Mar 25 '20 08:03 ghost

** Under developing **

  • Add your language

https://github.com/effekseer/Effekseer/blob/master/Dev/release/resources/languages/languages.txt

For example, ru

  • Add CSV files

Copy this directory and rename it into ru. After that, change texts.

https://github.com/effekseer/Effekseer/tree/master/Dev/release/resources/languages/en

You can see some texts are changed when a language is changed from an option panel

durswd avatar Apr 05 '20 17:04 durswd

Excellent! Now it's much more convenient. I was expecting just that - one big file with strings. Tomorrow I'll try this new approach.

ghost avatar Apr 05 '20 19:04 ghost

Well, I couldn't test anything because my attemts to compile Effekseer failed. Too many errors. May be I do something wrong?

ghost avatar Apr 09 '20 17:04 ghost

Please paste errors.

durswd avatar Apr 10 '20 01:04 durswd

After my work, You can change a languages without compile... A menu can be changed with editing external texts on CI version.

https://dev.azure.com/Effekseer/Effekseer/_build/results?buildId=1593&view=artifacts&type=publishedArtifacts

durswd avatar Apr 10 '20 01:04 durswd

So, now I get Russian text but it looks monospace. Some word's combinations may be long and won't fit on a line. Снимок

ghost avatar Apr 10 '20 07:04 ghost

  • What about this text

On codes. I need to migrate it.

https://github.com/effekseer/Effekseer/blob/master/Dev/Editor/EffekseerCore/Data/OptionValues.cs#L56

Should I implement a function to change a font?

durswd avatar Apr 10 '20 11:04 durswd

On codes. I need to migrate it.

Aah, I got it.

Should I implement a function to change a font?

Yes, I think so. Because the font we use now looks a little weird. Moreover, if we use it in tooltips, for instance, it'll be difficult to read.

Снимок-correct

The second option looks more familiar, right? ;-)

ghost avatar Apr 10 '20 12:04 ghost

OK. I 'm going to implement at this week end.

durswd avatar Apr 10 '20 12:04 durswd

You now can change a font from external

https://github.com/effekseer/Effekseer/commit/dbb33165d4081ba6175e4da8cd94f6e2886dea3d

durswd avatar Apr 11 '20 12:04 durswd

Now you can change a language in Option panel like this.

https://github.com/effekseer/Effekseer/commit/eeef3119d5d6f7dbdd8a7dc1a2aedac172a198b3

durswd avatar Apr 11 '20 14:04 durswd

Excuse me. I finished to convert Position and Rotation into CSV But I need more time to complete this work.

durswd avatar Apr 19 '20 15:04 durswd

Hi! Yes, I saw new files. I even tried to translate some of them. But I coulnd’t test them yet because Effekseer is still not compiled. Talking about it, could you give me another custom build of Effekseer, please? Then I will test an interface font at least. :-)

About your time. Don’t worry! Do as you feel comfortable. We are not in a hurry, because we have no deadlines.

ghost avatar Apr 20 '20 13:04 ghost

I will prepare it

durswd avatar Apr 20 '20 17:04 durswd

You can now download the latest version from github actions!

https://github.com/effekseer/Effekseer/actions

durswd avatar Apr 22 '20 12:04 durswd

Thanks! I've already download and checked the font in the interface. Everything works as it should! Well, I'm waiting for the further migration of strings.

I forgot to say. When you first start the program is in Japanese. Only icons helped me to find the right way. ;-)

ghost avatar Apr 22 '20 13:04 ghost

I forgot to say. When you first start the program is in Japanese. Only icons helped me to find the right way. ;-)

It is bug...

durswd avatar Apr 29 '20 16:04 durswd

I fixed it, please try the newest github action's version

durswd avatar Apr 29 '20 16:04 durswd

It's checked. Now Effekseer starts in English.

ghost avatar Apr 30 '20 05:04 ghost

I finished to make texts of RenderSettings external. It seem that I finished 50%...

durswd avatar May 05 '20 09:05 durswd

I'm sorry. I'm too busy to update to 1.6...

durswd avatar Aug 26 '20 18:08 durswd

It's OK! I watch the changes and see that v.1.6 need more work. So keep refining Effekseer. Stability is more prefered than localization. I'm in touch anyway.

ghost avatar Aug 27 '20 06:08 ghost