rot8 icon indicating copy to clipboard operation
rot8 copied to clipboard

Errors compiling release build due to strip cargo feature

Open mnussbaum opened this issue 2 years ago • 1 comments

Hi there, it looks like the strip Cargo feature was enabled, but this is causing some build time errors since that feature is only available on nightly, and is gated even there. When I compile with the --release flag on Cargo 1.58.0, with nightly enabled, I get the following:

$ RUSTUP_TOOLCHAIN=nightly cargo build --frozen --release --all-features
error: failed to parse manifest at `/home/mnussbaum/src/rot8/Cargo.toml`

Caused by:
  feature `strip` is required

  The package requires the Cargo feature called `strip`, but that feature is not stabilized in this version of Cargo (1.58.0-nightly (ad50d0d26 2021-11-17)).
  Consider adding `cargo-features = ["strip"]` to the top of Cargo.toml (above the [package] table) to tell Cargo you are opting in to use this unstable feature.
  See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#profile-strip-option for more information about the status of this feature.

mnussbaum avatar Oct 03 '22 00:10 mnussbaum

If I see this correctly, it has been stabilized in the 1.59 release, isn't it? what would be your suggestion otherwise? feel free to make a pull request.

efernau avatar Oct 13 '22 21:10 efernau