M. Efe Çetin

Results 109 comments of M. Efe Çetin

> Hi @efectn. I have two questions. What do you mean by **Should we integrate this into the client directly?** Can you explain it? Also, what should I do for...

> As I understood that I should remove it from `/middleware` directory and carry it to the root directory. If yes, it might be a problem for the config part....

> Also, what can I do with hooks? I don't have any idea what should I do. For example, we can execute hooks in each retry if user defined them....

> Yeah its a good idea. I like hooks, its a good solution for customization and give the possibility to extend our functionality. Btw we're not sure about `middleware/` is...

> > Yeah its a good idea. I like hooks, its a good solution for customization and give the possibility to extend our functionality. > > Can you provide an...

> > Now I need to use retry in client refactoring. I also think `middleware/` is not a good location, it might be a good idea to put it in...

> Hi again, > > Thanks for renaming @efectn. It seems the PR is ready to merge. I have a question to @ReneWerner87 about the latest comment. > > >...

> @balcieren @efectn Any updates on this? Waiting for: - https://github.com/dgrr/http2/issues/59 - https://github.com/dgrr/http2/issues/58

I reviewed this a bit today and this way seems good to me but i have a little question. Why don't we support map binding? I think we can add...

And we don't need default validator i think. Playground validator has too much and big sized indirect dependencies (https://github.com/gin-gonic/gin/issues/3165). But we can support custom validators by an struct validator interface.