M. Efe Çetin

Results 163 comments of M. Efe Çetin
trafficstars

Hi @mdelapenya. When i run couchbase tests with testcontainers-go, a timeout error raises after 30 seconds, especially with context tests; however, when i run tests with couchbase image on docker,...

> @efectn is it fine if I add some commits on top of yours updating the tests? Yes of course, feel free to play.

> @mdelapenya would be cool if you could support here as this is a breaking change and we want to improve the storage for v3 the new version is just...

> @efectn can i merge , or should i wait for the coverage extension ? ![image](https://private-user-images.githubusercontent.com/7063188/359886793-75228736-9ee4-4016-982e-51601c4b66ce.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyODI4ODgsIm5iZiI6MTcyNDI4MjU4OCwicGF0aCI6Ii83MDYzMTg4LzM1OTg4Njc5My03NTIyODczNi05ZWU0LTQwMTYtOTgyZS01MTYwMWM0YjY2Y2UucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjFUMjMyMzA4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTI3OWM0Yzc0MjA4MGIxMzQ4OWMxODNmZDRjZmI4YTY0Njc3YWEwMGMxNTI0MTlhMmE3Yjg5ZjkyZGU1MDU5NSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.SCIvZNNVRC-qdwO9AG4iimy7SqhOnQhUxRyGiNvPTcY) I will complete it tomorrow

> > @efectn If you can add the command for generating the `msgp` to the Makefile. > > you mean this [`main`/Makefile#L61-L67](https://github.com/gofiber/fiber/blob/main/Makefile?rgh-link-date=2024-08-29T14%3A05%3A39Z#L61-L67) done

You can use `fs.Sub` directly without converting it to http.FS. New static middleware accepts `fs.FS` as FS config property. I don't think you need that part.

Tested, it works. ```go package main import ( "embed" "io/fs" "log" "github.com/gofiber/fiber/v3" "github.com/gofiber/fiber/v3/middleware/static" ) // Embed the build directory from the frontend. // //go:embed fiber/* fiber/public/* var BuildFs embed.FS //...

There are a few of major tasks left back to release rc1 of fiber v3. I'd recommend you to develop your projects using v2 which is in stable state. v3...

I am OK with the change, too.