efck
efck copied to clipboard
Turning OFF 'person' does not hide 'person' emoji variants
Describe the bug
Disabling person
does not hide person
emoji variants
To Reproduce Steps to reproduce the behavior:
- Go to 'Options > Gender'
- Click on
man
and/orwoman
to turns ON - Click on
person
to turns OFF - See error
Expected behavior
Hide person
variants if is person
is turned OFF, while man
and/or woman
is turned ON.
Versions Specify versions: OS: Linux (Debian 11) Qt: 5.15.2 EFCK: 1.0
Additional context, screenshots
I see we just do a rudimentary scan for "person": https://github.com/efck-chat-keyboard/efck/blob/096a7b6cc4004911c06337fa736a25ac67e1e628/efck/emoji.py#L26-L30 but a "person emoji" is apparently any "X" for which also "man X" and "woman X" exist: https://github.com/efck-chat-keyboard/efck/blob/096a7b6cc4004911c06337fa736a25ac67e1e628/efck/emoji-ordering.txt#L845-L857 :thinking:
Is it Unicode version: 12.1
and 4.0
?
U+1F9D1 U+200D U+2695 U+FE0F ; 12.1 # 🧑⚕️ health worker
...
U+1F468 U+200D U+2695 U+FE0F ; 4.0 # 👨⚕️ man health worker
If so, maybe it needs to add setting for "Unicode version" in "Options".
N.B. In Android app "UnicodePad" there is Unicode version setting for compatibility issues:
- https://github.com/Ryosuke839/UnicodePad
Is it Unicode version: 12.1 and 4.0?
Those are just Unicode versions that introduced the symbol. Unreliable and not future-compatible.
I'd rather not (have the user) filter by Unicode version. We simply enumerate all the glyphs from the latest (vendored) Unicode standard, and the user might see some of the emoji icons blank, depending on the platform/font availability.