iothrottler icon indicating copy to clipboard operation
iothrottler copied to clipboard
Published 4 years ago • verified publisher icon efarrer

Update iothrottler.go

Open MomentoSystems opened this issue 4 years ago • 1 comments

Must be a non-negative value in Bandwidth

MomentoSystems avatar Nov 27 '21 11:11 MomentoSystems

Thanks for posting this PR. The unit tests pass, but I'm concerned this may introduce a bug. For example on lines 99-101 of iothreottler.go we account for a variable of type Bandwidth being negative. I'm wondering if a better fix would be to check for negative bandwidth in NewIOThrottlerPool and SetBandwidth. What are your thoughts on this proposal?

efarrer avatar Nov 30 '21 19:11 efarrer