openlane2 icon indicating copy to clipboard operation
openlane2 copied to clipboard

hotfix: flatten while generating JSON headers

Open kareefardi opened this issue 1 year ago • 1 comments
trafficstars

Steps

  • Odb.SetPowerConnections

    • Fixed bug where instances with special characters in their name and power pins are not equal to those of the SCL would not get connected.
    • Added assertion that exactly one pin is connected for every operation.
  • Yosys.GenerateJSONHeader

    • Netlist is now flattened so Odb.SetPowerConnections can properly set pins for nested macros with power pin names not equal to those of the SCL.

Testing

  • test/designs/dual_spm
    • SPM macro now hardened with pin names power, ground (as to not match the standard cell pin names)
    • Dual SPM now nests the macros in a thin wrapper to test that the SPM macro will get its power pins connected properly.

Depends on https://github.com/efabless/openlane2-ci-designs/pull/27

kareefardi avatar Apr 23 '24 16:04 kareefardi

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-main <path to directory>.

  • No changes to critical metrics were detected in analyzed designs.

Full tables ► https://gist.github.com/openlane-bot/19ea81129ea364042f3ab65f3199afac

openlane-bot avatar Apr 23 '24 16:04 openlane-bot