openlane2 icon indicating copy to clipboard operation
openlane2 copied to clipboard

Upstream antenna patch

Open mole99 opened this issue 1 year ago • 3 comments

Description

Are there any plans to upstream this patch here: nix/patches/openroad/antenna.patch

Using a locally compiled OpenROAD without it leads to a failure in Odb.CheckDesignAntennaProperties:

Error Message
AttributeError: 'dbMTerm' object has no attribute 'hasDiffArea'. Did you mean: 'getDiffArea'?                                                                                        
[09:11:34] ERROR      File "/usr/lib/python3/dist-packages/click/core.py", line 754, in invoke                                                                           step.py:1170
                        return __callback(*args, **kwargs)                                                                                                                           
                      File "/usr/local/lib/python3.10/dist-packages/openlane/scripts/odbpy/reader.py", line 205, in wrapper                                                          
                        function(**kwargs)                                                                                                                                           
                      File "/usr/local/lib/python3.10/dist-packages/openlane/scripts/odbpy/check_antenna_properties.py", line 109, in check_antenna_properties                       
                        report = check_cells(cells)                                                                                                                                  
                      File "/usr/local/lib/python3.10/dist-packages/openlane/scripts/odbpy/check_antenna_properties.py", line 34, in check_cells                                     
                        has_diff_area = mterm.hasDiffArea()                                                                                                                          
                    AttributeError: 'dbMTerm' object has no attribute 'hasDiffArea'. Did you mean: 'getDiffArea'?

Thanks!

Proposal

Upstream the patch to OpenROAD

mole99 avatar Mar 04 '24 08:03 mole99

@kareefardi I think we discussed upstreaming this but we stalled because we were busy with release…? What's the status on this?

donn avatar Mar 04 '24 09:03 donn

https://github.com/The-OpenROAD-Project/OpenROAD/pull/4733

kareefardi avatar Mar 04 '24 10:03 kareefardi

This will likely be address by https://github.com/efabless/openlane2/pull/436

kareefardi avatar Mar 27 '24 09:03 kareefardi

Done in dev

donn avatar Jul 03 '24 15:07 donn