caravel_board icon indicating copy to clipboard operation
caravel_board copied to clipboard

Makefile should not mess up with the $PATH

Open proppy opened this issue 2 years ago • 2 comments

This currently break integration with currently activated venv or conda environment:

$ python3 -m venv env
$ source env/bin/activate
$ python -m pip install mpremote
$ cd firmware_vex/nucleo/
$ make run
mpremote connect /dev/cu.usbmodem34203 exec "import machine; machine.reset()"
/bin/sh: 1: mpremote: not found

If you remove the line at https://github.com/efabless/caravel_board/blob/main/firmware_vex/nucleo/Makefile#L2 it works as expected (mpremote get resolve from the currently activated environment).

proppy avatar Jan 12 '23 11:01 proppy

This thread should be helpful. https://open-source-silicon.slack.com/archives/C022XAPHD9C/p1673043313859249

ayushman22git avatar Jan 13 '23 04:01 ayushman22git

https://github.com/proppy/caravel_board/commit/ce91da71f58b7d456957d71ee5c45a71f3bb7d4c was enough for me for the Makefile to pick up things in my local venv.

proppy avatar Jan 18 '23 04:01 proppy