caravel icon indicating copy to clipboard operation
caravel copied to clipboard

gpio_control_block.def is out of date

Open antonblanchard opened this issue 2 years ago • 1 comments

Commit b2089fe9eb2d updated the mag and gate level views, but the def was not. This breaks hierarchical STA (eg make caravel_timing_typ).

Note: The spef view was also not updated, but at least it can be regenerated simply via rcx-gpio_control_block

antonblanchard avatar Aug 30 '22 10:08 antonblanchard

There are multiple issues that need to be resolved with gpio_control_block; for one, the timing issue between control blocks has been fixed but is currently in branch fix_serial_loader_data_timing. I have not issued a pull request because this block needs to be re-synthesized and verified, and all views (including DEF, LEF, .mag, gate-level verilog) updated. Then it can be merged into main.

@shalan : Please make sure that this block gets rehardened. This is a critical fix.

RTimothyEdwards avatar Sep 02 '22 14:09 RTimothyEdwards

@antonblanchard I am afraid to say that hierarchical STA does not work anymore as intended due to limitations in the current OpenSTA release. Please don't rely on it as the top-level interconnect parasitics are not used/seen by OpenSTA. This has been confirmed by the OpenROAD team.

shalan avatar Sep 07 '22 13:09 shalan

@RTimothyEdwards @antonblanchard The updated gpio_control_block was hardened a while back but not pushed. @kareefardi please push it.

shalan avatar Sep 07 '22 13:09 shalan

This will be replaced by a new DEF, since the block needs to be rehardened.

RTimothyEdwards avatar Oct 05 '22 19:10 RTimothyEdwards