ember-cli-deploy-git icon indicating copy to clipboard operation
ember-cli-deploy-git copied to clipboard

"Could not find app javascript" when following docs on an embroider app

Open gitKrystan opened this issue 3 years ago • 1 comments

I have a brand new app using embroider for builds, and I'm trying to deploy with ember-cli-deploy-git. Following the instructions in the README, I ran into this error:

Error: Could not find app javascript: "/assets/docs.js" in index.html. Found the following instead:
 - /event-perk-grid/assets/vendor.js
 - /event-perk-grid/assets/docs.js

For more information about this error: https://github.com/thoov/stitch/wiki/Could-not-find-asset-in-entry-file-error-help

After a lot of hand-wringing, I figured out that I need a trailing slash in my rootURL.

Maybe the docs should suggest ENV.rootURL = '/your-repo-name/'; instead of ENV.rootURL = '/your-repo-name';? I'd be happy to PR it if so.

gitKrystan avatar Feb 17 '22 00:02 gitKrystan

Thanks for this report, this is definitely an annoying problem.

A docs PR would be great, or also a PR that would automatically ensure that Embroider always interprets the rootURL as if it has a trailing slash.

ef4 avatar Mar 27 '22 22:03 ef4