SWATEliteForce
SWATEliteForce copied to clipboard
Remove Gamespy without influence
Gamespy has disabled its services, so SEF does not need Gamespy Profile anymore.
Tested and I could not find any errors.
Is there a noticeable difference ingame when it is removed? I agree that Gamespy stuff should removed and I will review this PR but I am curious if there is a tangible difference either way with the code being in there or not.
So this PR only aims to remove the GamespyProfilePopup because you can no longer login with the GamespyProfilePopup. What are the advantages? I would say that it cleans the code which is always a great thing. And if this popup appears the player will not be confused. So I don't think I've ever seen this popup before, but it shows that it's unnecessary. Of course you could remove Gamespy completely but I don't know how much dependencies there are in multiplayer so I'll leave it at that for now. I know now that the internet mode is partly dependent on Gamespy entries. That means you would probably have to rename and adapt a lot.
So I suggest to test the existing changes first. I can't find any differences concerning the serverlist. However, I can't load missions with the SEF GitHub version so I can't join any server. I assume that these changes have no effect. Once the changes are tested I can continue and then I could try to remove the last remnants of Gamespy and adjust it, for example renaming the GameSpy buttons in the server menu.