modular-psu-firmware icon indicating copy to clipboard operation
modular-psu-firmware copied to clipboard

Function Generator - Zoom Glyphs Swapped

Open PalantirWielder opened this issue 3 years ago • 2 comments

FuncGenZoom

Function Generator screen (v1.7.1) has three items along the top (Left to Right):

  1. Time Scale : Status
  2. Zoom Out (-) : Button
  3. Zoom In (+) : Button
  • Pressing "Zoom Out" instead zooms in, showing less of the overall plot and more detail.
  • "Zoom In" instead zooms out, showing more overall plot and less detail.

This icon-functionality pairing is inconsistent with the graph zooming in EEZ Studio, as well as most application/web GUIs.

If I'm reading the code correctly it appears that the Zoom In/Out Naming & Functionality are correctly associated: https://github.com/eez-open/modular-psu-firmware/blob/868a26ec3c8e529707a1c6172ae48c26df0d987e/src/eez/function_generator.cpp#L3069 https://github.com/eez-open/modular-psu-firmware/blob/868a26ec3c8e529707a1c6172ae48c26df0d987e/src/eez/function_generator.cpp#L3079

Perhaps the Zoom In/Out glyphs are just swapped?

PalantirWielder avatar Aug 14 '21 07:08 PalantirWielder

Does anyone know where the button-glyph association is made in the firmware?

PalantirWielder avatar Aug 24 '21 15:08 PalantirWielder

It appears that the Button-Glyph association is within the "modular-psu-firmware.eez-project"

Pages / sys_settings_function_generator / Components / Container: Preview period / Widgets / Button / function_generator_preview_period_zoom_in

and:

function_generator_preview_period_zoom_out

"Zoom In" glyph is set to \\u00b9 "Zoom Out" glyph is set to \\u00b8

image

As can be seen in the Glyph Browser, these icon associations are swapped.

Also worth noting is that unlike the Function Generator GUI, dlog_view_zoom_in, dlog_view_zoom_out, and the EEZ Studio Graph Viewer buttons have their glyphs correctly assigned.

@prasimix, what is the preferred method for submitting code fixes?

PalantirWielder avatar Aug 26 '21 21:08 PalantirWielder