postgres-backup-s3 icon indicating copy to clipboard operation
postgres-backup-s3 copied to clipboard

Published 20 hours ago • verified publisher icon eeshugerman

Support for backing up all databases

Open JJGadgets opened this issue 1 year ago • 2 comments

The schickling image supports using pg_dumpall to backup all databases within a Postgres instance/cluster.

https://github.com/schickling/dockerfiles/blob/master/postgres-backup-s3/backup.sh#L65-L88

Could this also be supported in this image? This is the only missing feature holding me back from using this image over schickling's, as I'd like to have the backup be a "set it and forget it" cronjob even as more databases are added.

Would be open to try implementing it myself (will be testing against CloudNative-PG) and PR'ing the changes assuming all goes well.

JJGadgets avatar May 29 '23 04:05 JJGadgets

Interesting, I didn't realize the schickling repo is still merging new code.

Anyway, yes, I would be open to merging a PR for this.

eeshugerman avatar May 30 '23 15:05 eeshugerman

@JJGadgets just curious, whats is your reason to want to switch to eeshugerman's image over schickling's? For me its BACKUP_KEEP_DAYS. Ik it can be automated with cron s3 command but since its built-in, its quite convenient!

vutsalsinghal avatar Jun 07 '23 23:06 vutsalsinghal