postgres-backup-s3 icon indicating copy to clipboard operation
postgres-backup-s3 copied to clipboard

Published 20 hours ago • verified publisher icon eeshugerman

feat: Use backup directory, refact dockerfile

Open pratikbin opened this issue 2 years ago • 4 comments

pratikbin avatar May 04 '22 21:05 pratikbin

Hi, thanks for the PR! #17 is a usecase I'm interested in supporting. But I can't accept this as is; there are far too many unnecessary, unrelated changes. If you provide a patch with minimal changes for #17, I will consider merging.

eeshugerman avatar May 07 '22 22:05 eeshugerman

If you provide a patch with minimal changes for https://github.com/eeshugerman/postgres-backup-s3/issues/17, I will consider merging.

There are

Major

  • Move install.sh to dockerfile
  • Add backup directory in backup.sh

Minor

  • chmod +x both backup and restore file, since git preserve permissions

So if you want me to break down these changes in separate PR, then let me know

pratikbin avatar May 08 '22 06:05 pratikbin

@eeshugerman Any updates to get this merge ?

pratikbin avatar Jun 23 '22 16:06 pratikbin

Hi, sorry for the delay. Thanks for the breakdown of changes here.

I don't want to get rid of install.sh unless we have a good reason to, so I'm not going to merge this as-is.

If you open a separate PR with only the backup/ directory changes, and another PR with only the chmod +x changes, I will likely merge them both.

eeshugerman avatar Jul 03 '22 15:07 eeshugerman