Eero Tamminen

Results 721 comments of Eero Tamminen

> There is this overview on the migration to v6, https://github.com/orgs/collectd/projects/1 > A lot of plugins are not migrated yet, and iirc we have issues filed for them. Is somebody...

I checked commits in several of the few dozen migration PRs by @manuelluis, and none of them included "Fixes:" tag. @elfiesmelfie seems to have linked several of them (all?) to...

I would also be in favor of simplifying the plugin. Something that is nowadays used just to generate (Prometheus) ASCII output, shouldn't look that complicated.

Above "write_prometheus: migration to v6.0" PR which removes protobuf support has been merged, so this can be closed.

> is that support also removed from collectd 5.x? @elfiesmelfie No, nobody has proposed similar PR for "main" branch. I've already switched to v6 branch and would suggest that to...

In general this sounds good, but I was wondering about this: > This meant that all write plugins would have to cooperate in order to not drop values. If for...

> Oh, I first assumed that that was a false positive. Will fix in the next version. Note that there are few helper / wrapper functions in: https://github.com/collectd/collectd/blob/collectd-6.0/src/utils/common/common.h#L75 Btw. Have...

>> Btw. Have you checked whether your change has any measurable memory or performance impact on collectd? > > Not really. We can't do too much real world testing until...

@hnez Have you been able to run your changes under memory access & thread debugging tools?

Thanks, all that sounds really great! [Hellgrind] > Did produce quite a bit of output that I am not too sure about how it should be interpreted. I've pasted one...