Emre Erkunt

Results 114 comments of Emre Erkunt

Hi again, It looks like this requires an enhancement on `terraform-compliance`. I have a feeling this can be done if the `kms_key` was a `resource`, not a `data`, because we...

Thanks for the issue. I agree there is a problem there and found out why the tool is failing on this specific scenario. We have to implement `Feature`->`HCL` and `HCL`->`Feature`...

Just giving an update, we are about to finalise the refactoring of the Security Groups feature that will not only fix this problem but also will be extendable for other...

Hi @mjseid , Can you please have a try with the new release ? 🎉

Hmm, according to the [documents](https://terraform-compliance.com/pages/bdd-references/then.html#then--it-must-condition-have-proto-protocol-and-port-port-for-cidr) it is following the rules ? Because you are using `must only` condition in your tests, the test will have a look on both ;...

What was your exact expectation ? Just after reading your message, I think I need to implement a similar step to ; ```cucumber Then it must only have tcp protocol...

Hi, You can do it actually, in a way. Instead of `must only`, you can just say `must`, but again the port & cidr superset matching will be executed per...

I will create a new step for going over ALL security groups ( not one by one ) ; ```cucumber Then all must only contain tcp protocol and port 53,80,123,443...

Hi, Just had a look on this issue, just like @Kudbettin the tf files I created based on the example you described above just passes. Also plan file created from...

Yep, when I checked the `plan.out.txt` file you have sent, and the `plan.out.json` file I created via using your `main.tf.txt` with ; ``` ➜ terraform -version Terraform v0.14.10 + provider...