Philippe Proulx
Philippe Proulx
What do you propose? There are four `pos_to_rect_is_resizing_*()` checking for top/bottom/left/right conditions, and the four others reuse those four. All the `handle_ss_rz_*()` reuse the equivalent `rect_resize_*()`, which are pretty much...
Duly noted!
Follow-up: the recent CTF 2 specification proposal revision includes static-length and dynamic-length [BLOB field classes](https://diamon.org/ctf/files/CTF2-PROP-2.0.html#blob-fc). If this is accepted, it means you'll be able to use such a field class...
> Hello, Thank you for your interest in contributing to the project. This kind of review is much appreciated by the team. > > This is a proposal (working) implementation...
Fixes posted [here](https://review.lttng.org/c/babeltrace/+/4526) and [here](https://review.lttng.org/c/babeltrace/+/4528).
Also: our review process happens on [Gerrit](https://review.lttng.org/q/project:babeltrace). Please create one or more changes there when you're ready. If you're not familiar with the Gerrit workflow, see its [user guide](https://gerrit-review.googlesource.com/Documentation/intro-user.html).
> What branch would you want me to target for this work? `master`
> I posted this question to the mailing list, feel free to close if that's the preferred comms channel. Here is alright. Having such an automatic field could work indeed....
The packet sequence number was added to CTF to support the [overwrite mode](https://lttng.org/docs/v2.13/#doc-channel-overwrite-mode-vs-discard-mode) of an LTTng channel: > Since LTTng 2.8, with this mode, LTTng writes to a given sub-buffer...
Yes it would make sense for it to be part of `struct barectf_default_ctx` (let's call it this way), but the current generated API only offers a common initialization function which...