alien-minimal icon indicating copy to clipboard operation
alien-minimal copied to clipboard

dropped vi prompt support

Open pszypowicz opened this issue 8 months ago • 8 comments

Hi, I know we are not entitled for anything so this is really just a curiosity question, could you share why vi prompt support was dropped?

I spent some quality time in the morning on setup of new workstation and could not figure out why it did not work 😅

pszypowicz avatar Apr 21 '25 07:04 pszypowicz

Sorry about the inconvenience 😔

The last few changes I made seems to break the support. I don't use the vi prompt myself and does not have enough experience with it to fix the issue quickly. So I thought it would be better to remove the feature rather than keep it broken.

I will definitely give it another try.

eendroroy avatar Apr 21 '25 13:04 eendroroy

@pszypowicz I have added back the vi prompt feature. Could you please try it out (from development branch)

eendroroy avatar Apr 22 '25 07:04 eendroroy

Thank you! Was not expected such a quick reaction <3

I have tested it and:

old one:

Image

new one:

Image

I do not know why the new one shows "_" in the prompt. Also switch to "(n)" normal mode is delayed in the new one for about the second.

pszypowicz avatar Apr 22 '25 07:04 pszypowicz

I do not know why the new one shows "_" in the prompt.

Did you configure AM_PROMPT_START_TAG as _ somehow?

Also switch to "(n)" normal mode is delayed in the new one for about the second.

Will have to check.

eendroroy avatar Apr 22 '25 11:04 eendroroy

This is really my whole amrc file: https://github.com/pszypowicz/dotfiles/blob/main/dot-amrc

only

export AM_DIR_EXPANSION_LEVEL=2
export AM_ENABLE_VI_PROMPT=1

pszypowicz avatar Apr 22 '25 16:04 pszypowicz

These are the defaults.

AM_PROMPT_START_TAG='_'
AM_PROMPT_END_TAG='$'

You can either set them as empty string. Or even better if you customize the prompt sections. New amrc.zsh

This is what I am using right now: .amrc

eendroroy avatar Apr 24 '25 11:04 eendroroy

Hi, Thanks for changes, I applied almost 1 to 1 your amrc - with and addition of vi plus different dir expansion level.

So maybe the last part is just not instant feedback for the "normal" vi prompt.

btw I am on the master branch as of now.

pszypowicz avatar Apr 28 '25 07:04 pszypowicz

Feedback for "normal" mode is not instant because of the way I have implemented it. Before each feedback the whole prompt gets regenerated. I may have to change the implementation to get rid of the bug.

eendroroy avatar Apr 29 '25 06:04 eendroroy