Eemeli Aro

Results 571 comments of Eemeli Aro

I'm not aware of an established pattern on this, but I'd be happy to consider a PR adding memoization to this.

@harmitgoswami This is currently marked as a draft PR; could you clarify what sort of review you'd like of it, and/or what's still intended to be done to it?

Yeah, it may well be easier to first port tests from Enzyme to testing-library, and only then from Jest to Vitest.

This is a bit different from #3500, though, as that's about noticing better when entities _don't change_.

(Sorry for the delay, I've been on vacation the past two weeks) I agree that a definition of the `mf` namespace in XLIFF would be Really Good, but at least...

Could you clarify what you mean by "doesn't see these lines"? In Fluent, tabs are not recognised as whitespace.

If there's a discrepancy, we should resolve that. For that, could you share an ftl file which shows the difference?

Sorry for not getting to this earlier. It looks like there's a difference in `\r\n` newline treatment between `codecs.open` and the builtin `open`?

Apologies, I'd missed the original issue here. The complaint is fair. There's functionality in FluentBundle for this, but it should really be exposed to FluentLocalization as well. This is relatively...

Note that `hourCycle` is not an option recognised by Unicode MessageFormat. It might be set by a `-u-hc` subtag on a locale, but not as an option on e.g. `:datetime`....