Eemeli Aro

Results 571 comments of Eemeli Aro

> are there other areas you're aware of where stringify is used during parsing? Not sure; there could be something in error reporting. But keep in mind also that the...

@conartist6 That's doable, if you can show that users of the browser build would not be too negatively affected by the packaging change, and that users of the CJS build...

There is a real issue here, but I'm not sure if it _should_ be solved. By default, we assume that the content in YAML is human-readable, and that therefore it's...

> It sounds to me from what you're saying like a new major version that forces `mapAsMap: true` would be sufficient to unlock these gains, would it not? That would...

`null` as a key is parsed as a `!!null` scalar value. The issue that you're encountering is that the JS Object only supports string keys, and the `!!null` value is...

> I’m curious from your perspective, as the library author, why treating keys as strings isn’t the default behavior, given that traditionally POJOs are our mapping type in JS. Because...

> Is it incorrect to parse as strings? A casual scan of the spec suggests that it is not a problem. The default schema used by this library is the...

The newlines in the plain scalar are collapsed into spaces, so they're lost in the parsing. They are of course in the CST, but retaining them for Document stringification as...

I've added a fix making the first variant properly an error, i.e. ```yaml abc: | #this should be an error block scalar header requires +1 indentation ``` The second variant...