Eemeli Aro

Results 571 comments of Eemeli Aro

Yeah, those are hard. One improvement that they do suggest to me is that when a value does not fit on the same line with the key, it might make...

> split to a new line after each comma `,` This would not really work for property values that are e.g. localizable text. > avoid splitting a "word" around a...

I agree with @aphillips. Automating this would be more work and more complexity than it's worth.

The size of the diff here held me off from looking too closely for a while... Have you considered other approaches to speeding up `span_to_position`? The additional data you're looking...

I would prefer an approach that added the least cost to users who do not need the line/column position for all nodes. Always calculating the positions during the parse seems...

I don't think this should be closed yet, as we have not heard answers from outside our WG to any of the questions I pose above. It could well be...

Dropping the `out-of-scope?` label as that was about the LDML54 release.

As noted in mozilla/moz-l10n#7, we'll need to maintain Python 3.8 compatibility for now.

Yes, but the plugin still works fine with any version in the range, yes? If you need to ensure the same behaviour on multiple machines, you could include an exact...

Could you clarify how Gradle is relevant here? Does it somehow manage JS dependencies as well?