redux-persist-transform-filter icon indicating copy to clipboard operation
redux-persist-transform-filter copied to clipboard

Published 20 hours ago • verified publisher icon edy

"Maximum call stack size exceeded." triggered by version 0.0.18 [iOS]

Open webraptor opened this issue 7 years ago • 9 comments

Platform: iOS only; [Android is OK]

We've just upgraded to redux-persist-transform-filter: 0.0.18 and the following error is thrown. Unfortunately, the call stack isn't very useful.

Maximum call stack size exceeded.

initCloneObject
    index.js:1253:66
baseClone
    index.js:869:31
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
cloneMap
    index.js:1030:33
initCloneByTag
    index.js:1290:22
baseClone
    index.js:877:30
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
cloneMap
    index.js:1030:33
initCloneByTag
    index.js:1290:22
baseClone
    index.js:877:30
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
cloneMap
    index.js:1030:33
initCloneByTag
    index.js:1290:22
baseClone
    index.js:877:30
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17
baseClone
    index.js:891:12
<unknown>
    index.js:897:39
arrayEach
    index.js:140:17

screen shot 2018-06-20 at 16 41 24

webraptor avatar Jun 20 '18 13:06 webraptor

how does your state look like? could you provide a reproducible example? i can only test with android devices

edy avatar Jun 20 '18 13:06 edy

I think this happen when there are cyclic dependencies in redux store

sibelius avatar Jul 24 '18 18:07 sibelius

We finally managed to track the issue down on RN 0.57.5 . Created an issue with lodash.clonedeep as well.

Reverting to 0.0.17 fixes the problem.

webraptor avatar Jan 30 '19 09:01 webraptor

@sibelius we are using redux-persist-transform-filter exactly to eliminate objects that cannot be serialized. Disabling the redux-persist-transform-filter functionality in the app produces exactly errors specific to trying to serialize non-serializable objects with redux-persist.

webraptor avatar Jan 30 '19 09:01 webraptor

The issue on lodash was closed as it was the intended behaviour:

Hi @webraptor!

The recursive implementation of cloneDeep was by design with the shortcoming that in some rare cases it could run into stack size exceeded issues. I'm not how cloneDeep is being used but chances are a more specialized clone tailored to their scenario will be a better option.

With this in mind, alternatives to commit baddb0597eab5ded23f08d9d88111929b45dc693 should be considered because we can't really have production apps that may crash at any time...

webraptor avatar Jan 30 '19 14:01 webraptor

What about just using JSON.parse(JSON.stringify(state)) instead of cloneDeep(state)? Would that solve the issue?

edy avatar Jan 30 '19 14:01 edy

I'll try it out tomorrow and come back with the results.

webraptor avatar Jan 30 '19 14:01 webraptor

@edy unfortunately it doesn't work, error thrown is: JSON.stringify cannot serialize cyclic structures The circular structure is within actioncable (react-native-actioncable) which we actually try to blacklist.

Looked into the code for blacklisting a little more and looks like we should filter out blacklisted properties before creating a deepclone?

webraptor avatar Jan 31 '19 09:01 webraptor

yeah, i think that would be the best solution. the thing is, i didn't want to manipulate the state directly, so I deepcloned it.

edy avatar Jan 31 '19 10:01 edy