node-tvdb icon indicating copy to clipboard operation
node-tvdb copied to clipboard

Typescript rewrite

Open OmgImAlexis opened this issue 4 years ago • 2 comments

Not sure if this is worth opening or if I should just manage my own fork but this should get this repo back up and running. If you don't see any use in this feel free to close the PR.

Tests now pass. There are 2 sets of tests that needed to be removed. They'll need to be fixed at some point.

This closes https://github.com/edwellbrook/node-tvdb/pull/129 https://github.com/edwellbrook/node-tvdb/pull/142 https://github.com/edwellbrook/node-tvdb/pull/137 https://github.com/edwellbrook/node-tvdb/pull/135 https://github.com/edwellbrook/node-tvdb/pull/140 and https://github.com/edwellbrook/node-tvdb/pull/141

Most methods are now typed correctly instead of returning any so the users actually know what data is being returned.

I've also trimmed the package size.

dist/index.js   - 6.84 kB
dist/index.d.ts - 9.38 kB
Done in 3829ms
npm notice 
npm notice 📦  [email protected]
npm notice === Tarball Contents === 
npm notice 1.1kB LICENSE        
npm notice 6.8kB dist/index.js  
npm notice 1.4kB package.json   
npm notice 1.9kB README.md      
npm notice 9.4kB dist/index.d.ts
npm notice === Tarball Details === 
npm notice name:          node-tvdb                               
npm notice version:       6.0.0                                   
npm notice filename:      node-tvdb-6.0.0.tgz                     
npm notice package size:  5.7 kB                                  
npm notice unpacked size: 20.6 kB                                 
npm notice shasum:        7227520fa61c6073a38e07e6b571c5773b412cda
npm notice integrity:     sha512-c8fbrvLKx+OBV[...]lruOSYiv5p+Cw==
npm notice total files:   5                                       
npm notice 
node-tvdb-6.0.0.tgz

PING: @edwellbrook

OmgImAlexis avatar May 17 '20 11:05 OmgImAlexis

Travis should be swapped for github actions and a task should be added to run generate-docs and push to github docs.

OmgImAlexis avatar May 17 '20 11:05 OmgImAlexis

I'm happy to cleanup https://github.com/edwellbrook/node-tvdb/pull/114 if this is merged.

OmgImAlexis avatar May 17 '20 12:05 OmgImAlexis