mongoose-paginate icon indicating copy to clipboard operation
mongoose-paginate copied to clipboard

Published 20 hours ago • verified publisher icon edwardhotchkiss

Fix broken tests

Open fiznool opened this issue 7 years ago • 5 comments

I honestly don't know how anybody was using this plugin, it was so broken...

This PR fixes up the issues.

fiznool avatar Sep 29 '16 15:09 fiznool

Hmm, I see, lots of similar changes are in #73.

I'm happy to help out getting all of this lot merged together, the changes are fairly simple but very important, since the current npm version (5.0.1) just flat out doesn't work.

fiznool avatar Sep 29 '16 15:09 fiznool

@fiznool do you plan on taking the reigns and supporting this repo? Just wondering if we can rely on updates out of your fork or whether we need to fork and maintain this ourselves?

rclayton-the-terrible avatar Sep 30 '16 03:09 rclayton-the-terrible

@rclayton-the-terrible I'm happy to maintain the codebase, at least for the time being, so it can be stabilised somewhat.

fiznool avatar Sep 30 '16 06:09 fiznool

@niftylettuce :wave: I know you were looking for somebody to help maintain the repo. I think this might be your person :)

peterpme avatar Nov 04 '16 20:11 peterpme

Awesome - @fiznool can you get this cleaned up, documented, and then ping me? [email protected] - once you have a PR here ready to go - I will accept and give you NPM ownership. I don't have ability to give you ownership on here. Someone would need to contact GitHub and also relatives or friends for information regarding ownership in this scenario.

niftylettuce avatar Nov 09 '16 18:11 niftylettuce