virtualenv-clone
virtualenv-clone copied to clipboard
edwardgeorge
Submitting new feature, "--fixup" option to fix a virtualenv without moving it
Hey edward - I used your script when packaging some python applications, and wound up having to add a feature to make it work properly for my needs. Specifically I had an application we had to build as a limited user inside a build environment, and package it as an RPM; but the files needed to be deployed into /opt on the live system. So I built a full virtualenv in an arbitrary location under the build system, then ran your script with my new "--fixup" option on it. This prepares the virtualenv to be executed in a new location without actually moving the files, and let us package the RPM the way I needed to.
I'm submitting it back in the hopes that others will find the feature cool. I updated the readme to describe the feature. There were also a couple small bugs (like using hardcoded "python" instead of the discovered executable in the source directory) that I fixed inline. Enjoy.
hi, thanks for this addition, i'll take a look and merge when I next get a moment.
Great feature :+1: @akesterson can you rebase this against master and @edwardgeorge any chance of getting this in? It would really add benefit.. in the meantime I will fork.. thanks, great contribution, virtualenvs --relocatable doesn't quite do the job..
Undoubtably this is something that would be useful. I left this one as I thought the entire source could do with a bit of re-org to make this feature fit in a bit more naturally but I never found the time to do it. if you rebase as @farridav mentions that would be great. I still think the project should be re-organised for this feature but maybe we'll have to forego that for now.
any chance you could add some testing for the tests that @barberj kindly added to the project since this original pull-request?
Sorry, just now seeing this. yeah I'll take a look and see what I can do re: getting it rebased and tested.
@ericlundin I just got involved in maintaining this package and want to clear out the open PRs. I understand the use case here. Are you still interested in this project, and if so, would you be up for adding some tests to this?
