edwardcapriolo
Issue #28 Add Windows Support
Great work here. IT would be super great to get this merged. I realize it is an if statement nightmare :)
Yeah, sorry I've been MIA. It's failing tests on Linux, so I need to get a linux dev system up so I can see what I broke...
I have noticed in practical use of this on Windows, that if you stop/terminate debugging of a unit test, the forked process never gets closed. I could do something crufty such as when the process starts up, check to see if there's an existing process with the same binary path and kill it off first. Suggestions?
Hey no worries about the time. I only wanted to let you know that I will work to get anything merged with you. Possibly we need to find some qemu vbox setup to test.
As to your question:
{quote} that if you stop/terminate debugging of a unit test, the forked process never gets closed {quote} I have noticed this too. I am not sure what that is. My thinking is the way to handle this might be to insert a magic string into the command line and a shutdown hook to kill the process off. But again you never know when/if the hook will fire. If you get an idea on this let me know.
Huh. Wouldn't you know it. I got a dev environment with CentOS 7.1 and ran the unit tests under Eclipse and they're all working. I'm trying to grock the travis-ci log...it appears that cassandra didn't terminate in one of the tests, but I'm not seeing it.
The travis-ci is a bit flaky. If something weird try a second push being that random failures happen.
Did you ever get this working? I landed ina windows env and even with cygwin I run into issues with /bin/bash not found
I never completed the merge, but could send you what I have. We do have it working, though there are some issues with abnormal termination.
On Thu, Apr 4, 2019, 11:56 AM Edward Capriolo [email protected] wrote:
Did you ever get this working? I landed ina windows env and even with cygwin I run into issues with /bin/bash not found
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/edwardcapriolo/farsandra/pull/34#issuecomment-479957228, or mute the thread https://github.com/notifications/unsubscribe-auth/AD09L4amoFyoHjJX359TCPvQBpWOey2oks5vdiCtgaJpZM4JdrCm .