tornadofx2 icon indicating copy to clipboard operation
tornadofx2 copied to clipboard

Kotlin 1.4.x

Open JacekWicka opened this issue 3 years ago • 4 comments

JacekWicka avatar Mar 31 '21 12:03 JacekWicka

#12 and this one may require changes in documentation i.e. https://edvin.gitbooks.io/tornadofx-guide/content/part1/11_Editing_Models_and_Validation.html

JacekWicka avatar Apr 01 '21 11:04 JacekWicka

Kotlin versions above 1.3.72 seem to bring about a bug that we need to fix before merging this - see here: https://github.com/edvin/tornadofx/issues/1324

SKeeneCode avatar Apr 10 '21 23:04 SKeeneCode

Just tried with Kotlin 1.5.21, Gradle 7.3.3 and JavaFX 17.0.1 and looks good. Might be able to jump to Kotlin 1.6 immediately. @JacekWicka mind if I make a PR to 1.0-candidate using your changes?

SKeeneCode avatar Dec 23 '21 12:12 SKeeneCode

@JacekWicka mind if I make a PR to 1.0-candidate using your changes?

I'm glad to hear, it's useful. Go on, please.

JacekWicka avatar Dec 28 '21 12:12 JacekWicka