tornadofx icon indicating copy to clipboard operation
tornadofx copied to clipboard

Muting docking in my own implementation of InternalWindow

Open balage1551 opened this issue 4 years ago • 1 comments

I am developing a single-window app and was quite happy to find the InternalWindow feature in Tornadofx. However, I need to add some features to the InternalWindow (special styling, title styling, etc.). InternalWindow is final, so I decided to make the unpractical action and started to implement my own InternalWindow based on the code of the original one. The problem with this approach (over the bad-practice) that there are two features the code uses, which are marked internal in the code. One is the muting of dock events, the other is the call of view.callOnUndock() when closing the window. So I left out these, but it has some side effects (like calling the onDock event each time a window is displayed, or by loosing the finalization steps in callOnUndock.

Is there any way, a workaround to achieve the same effects without using these features?

balage1551 avatar Jun 10 '20 10:06 balage1551

for single-window app you can use workspace it come with tow navigating mode tabs and stack

mostfa-ayad avatar Jun 16 '20 16:06 mostfa-ayad