fxlauncher-gradle-plugin icon indicating copy to clipboard operation
fxlauncher-gradle-plugin copied to clipboard

Plugin fails to apply when using Gradle plugin repository

Open jpd236 opened this issue 6 years ago • 3 comments

Tried using the new plugin DSL with the 1.0.18 plugin (now in the gradle repository, per #16).

plugins {
    id 'no.tornado.fxlauncher' version '1.0.18'
}

But I'm getting the following error:

...
Caused by: org.gradle.api.plugins.InvalidPluginException: An exception occurred applying plugin request [id: 'no.tornado.fxlauncher', version: '1.0.18']
	at org.gradle.plugin.use.internal.DefaultPluginRequestApplicator.exceptionOccurred(DefaultPluginRequestApplicator.java:247)
	at org.gradle.plugin.use.internal.DefaultPluginRequestApplicator.applyPlugin(DefaultPluginRequestApplicator.java:229)
	... 96 more
Caused by: org.gradle.api.internal.plugins.PluginApplicationException: Failed to apply plugin [id 'no.tornado.fxlauncher']
	at org.gradle.api.internal.plugins.DefaultPluginManager.doApply(DefaultPluginManager.java:150)
	at org.gradle.api.internal.plugins.DefaultPluginManager.apply(DefaultPluginManager.java:125)
	at org.gradle.plugin.use.internal.DefaultPluginRequestApplicator$3.run(DefaultPluginRequestApplicator.java:151)
	at org.gradle.plugin.use.internal.DefaultPluginRequestApplicator.applyPlugin(DefaultPluginRequestApplicator.java:225)
	... 96 more
Caused by: groovy.lang.MissingPropertyException: Could not get unknown property 'jar' for task set of type org.gradle.api.internal.tasks.DefaultTaskContainer.
	at org.gradle.internal.metaobject.AbstractDynamicObject.getMissingProperty(AbstractDynamicObject.java:83)
	at org.gradle.internal.metaobject.AbstractDynamicObject.getProperty(AbstractDynamicObject.java:61)
	at org.gradle.api.internal.tasks.DefaultTaskContainer_Decorated.getProperty(Unknown Source)
	at org.codehaus.groovy.runtime.callsite.PogoGetPropertySite.getProperty(PogoGetPropertySite.java:50)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callGetProperty(AbstractCallSite.java:296)
	at no.tornado.fxlauncher.gradle.FXLauncherPlugin.apply(FXLauncherPlugin.groovy:53)
	at no.tornado.fxlauncher.gradle.FXLauncherPlugin.apply(FXLauncherPlugin.groovy)
	at org.gradle.api.internal.plugins.ImperativeOnlyPluginTarget.applyImperative(ImperativeOnlyPluginTarget.java:42)
	at org.gradle.api.internal.plugins.RuleBasedPluginTarget.applyImperative(RuleBasedPluginTarget.java:50)
	at org.gradle.api.internal.plugins.DefaultPluginManager.addPlugin(DefaultPluginManager.java:164)
	at org.gradle.api.internal.plugins.DefaultPluginManager.access$200(DefaultPluginManager.java:47)
	at org.gradle.api.internal.plugins.DefaultPluginManager$AddPluginBuildOperation.run(DefaultPluginManager.java:252)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:336)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:328)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:199)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:110)
	at org.gradle.api.internal.plugins.DefaultPluginManager.doApply(DefaultPluginManager.java:144)
	... 99 more

The old system of adding a buildscript dependency and calling "apply plugin" continues to work fine.

jpd236 avatar Jun 30 '18 14:06 jpd236

I'm quite fond of the new id plugin DSL, so I'll be sad if it's broken.

TurekBot avatar Dec 20 '18 20:12 TurekBot

@aalmiray, do you have any idea why this might be happening?

TurekBot avatar Jun 21 '19 18:06 TurekBot

I think there's a change in the Gradle API. The code in question is

dependsOn: project.tasks.jar

I think the preferred way now is

dependsOn: project.tasks.findByName('jar')

This project relies on Gradle 2.13 (veeeery old) to build itself and publish. It may be the case that @jpd236 applied the plugin in a build that uses a more recent Gradle version.

aalmiray avatar Jun 21 '19 20:06 aalmiray