Edvin Syse

Results 153 comments of Edvin Syse

Great start. I will wait with merging until it works with J11, OK?

I don't have time to work on this at the moment. Eventually I'll update it when I need to use JDK13+ myself, but in the mean time anyone is free...

You need to post your deployment descriptor as a bare minimum :)

Hey guys, sorry about the late reply. I'm extremely busy these days, and will be for a few more weeks. I haven't looked at the PR in detail yet, and...

With the recent announcement that JavaFX will be removed from the JDK, we will not be targeting JDK9, but rather the decoupled JavaFX library once it becomes available.

That's a neat trick, but for 2.0 I think JSON would make more sense :)

JSON support can be included in a couple of small classes. 2.0 will require your users to download a new installer anyways, so backwards compatibility for the manifest is not...

It's not a good idea to have dependencies in the custom launcher ui. When you run `java -jar fxlauncher.jar`, the dependencies will not be on the classpath, hence the error...

There are several build tools that can help you with embedding other classes inside a single jar, for example the fatjar maven plugin. Not sure I understand your other questions,...

That sounds reasonable to me, but I have never used spring boot and I don't know the reasoning behind doing it this way. Hopefully the author of that function will...