apple icon indicating copy to clipboard operation
apple copied to clipboard

Published 20 hours ago • verified publisher icon eduvpn

remove libsodium dependency: apple crypto has ed25519 now

Open fkooman opened this issue 6 years ago • 11 comments

https://developer.apple.com/documentation/cryptokit/curve25519/signing

However, only iOS 13+ and macOS 10.15+. So for our "combined" app this may be acceptable?

This could replace the libsodium dependency (for checking the signatures over the discovery files).

fkooman avatar Dec 02 '19 10:12 fkooman

@efef is it acceptable to only support iOS 13+ and macos 10.15+?

ghost avatar Dec 02 '19 10:12 ghost

This ties in very well with #95 :)

Current deployment target for iOS is 11.0. Current deployment target for MacOS is 10.13.

jeroenleenarts avatar Dec 02 '19 11:12 jeroenleenarts

This could also open up the door to some cleanup in our Crypto class. #151

jeroenleenarts avatar Dec 02 '19 11:12 jeroenleenarts

So far we always said we'd minimal support newest OS and one version below. For the MacOS-port we'll first deliver a 10.15 only release, because 10.14 has IPv4 issue. But we'd like to phase-out the old macOS app. So in the end I'd support both 10.15 and 10.14.

Regarding iOS, students tend to have old phones, so I'd say try to be compatible with 11.0 and up.

efef avatar Dec 03 '19 20:12 efef

All iOS 11 devices can upgrade to iOS 12. So would it be ok to drop iOS 11 as a target?

jeroenleenarts avatar Dec 03 '19 21:12 jeroenleenarts

sure

efef avatar Dec 03 '19 22:12 efef

This is most likely an issue we can revisit in September 2020. When iOS 13 and MacOS 10.15 become the "old" platform versions.

For now, on iOS 13 and MacOS 10.15 we are in fact using CryptoKit instead of libSodium.

jeroenleenarts avatar Dec 08 '19 21:12 jeroenleenarts

It looks like we will revisit this in September 2021.

jeroenleenarts avatar Mar 01 '21 06:03 jeroenleenarts

I do hope we have a better reason to up the minimum supported OS version than just so we can drop a dependency, which afaik hasn't given us any issues. While for us developers it's always nicer to just have to support modern versions, some users just can't upgrade for various reasons.

johankool avatar Mar 01 '21 08:03 johankool

@efef We're a year later again. Is it time to up the minimal supported version to iOS 13? I wouldn't mind doing this bit of work.

jeroenleenarts avatar Aug 08 '22 14:08 jeroenleenarts

@jeroenleenarts:

We cannot drop the dependency on libsodium because we use Blake hashing for minisign prehashed signatures (#427), and Blake hashing is not offered by CryptoKit as yet.

We can move to Swift packages and drop CocoaPods already (#477).

So there's no point in dropping support for iOS 12 at present.

I actually think we can close this issue because we need to continue using libsodium.

roop avatar Aug 18 '22 08:08 roop