react-virtual-kanban
react-virtual-kanban copied to clipboard
onDropRow is not called when a row item is dropped outside of a row drop target
I integrated this with firebase so im relying on onDropRow
and onDropList
to update their position in firebase. The position in frontend is okay and updated, but those callbacks are not called when i dropped them outside of a drop target so i cant update the firebase.
I forked and applied a quick fix in v.0.2.0 to still use it https://github.com/imajean/react-virtual-kanban/commit/fc6ae26e425158fc6cfa6651b868a2ff53e80787
Hi @imajean I'm currently working on the 0.3.0 version of the library, in which I've added onDragEndRow
callbacks that you may be interested in. It's not exactly what you've proposed but it may serve to your purpose. I've kept drop and drag behaviors separated, so you don't have to differentiate whether it was a valid drop or not. Also onDragEndRow
is guaranteed to be called after every started dragging action.
You can try it out by using the latest master commit (bdc65f6). Let me know if you have any problems or got some feedback :wink: